Skip to content

Fix title for bootloader config.#2635

Merged
limetech merged 2 commits into
unraid:masterfrom
SimonFair:ZFS-reserved-name-check-
May 12, 2026
Merged

Fix title for bootloader config.#2635
limetech merged 2 commits into
unraid:masterfrom
SimonFair:ZFS-reserved-name-check-

Conversation

@SimonFair
Copy link
Copy Markdown
Contributor

@SimonFair SimonFair commented May 12, 2026 •
edited by coderabbitai Bot
Loading

Title for section was saying syslinx when it was grub.

image

This pr now fixes the bootloader name

image

Summary by CodeRabbit

  • Improvements
    • Boot configuration preview header now shows a generic "Current Bootloader Configuration" label and automatically updates to indicate either GRUB or Syslinux configuration based on the detected bootloader, ensuring the displayed preview matches your system.

Review Change Stack

@SimonFair SimonFair added the 7.3 label May 12, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 46967be4-e3d9-4226-b3f1-c80b32acf976

📥 Commits

Reviewing files that changed from the base of the PR and between 8b002bb and 76537e2.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix/BootParameters.page
🚧 Files skipped from review as they are similar to previous changes (1)
  • emhttp/plugins/dynamix/BootParameters.page

Walkthrough

The configuration preview header now dynamically displays the bootloader type. The HTML element is assigned an id for JavaScript targeting, and during configuration loading, logic updates the label text to reflect either GRUB or Syslinux.

Changes

Bootloader Configuration Label

Layer / File(s) Summary
Dynamic bootloader type-aware header label
emhttp/plugins/dynamix/BootParameters.page		 Header element receives id="current-config-label" for dynamic updates. During loadCurrentConfig() success, JavaScript detects bootloaderType and sets the label to "Current GRUB Configuration:" or "Current Syslinux Configuration:" accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops to check the view,
Labels swap from old to new,
GRUB or Syslinux in its sight,
JavaScript makes the header right,
Hooray — the preview greets the cue! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix title for bootloader config.' directly addresses the main change: correcting the bootloader configuration section header to dynamically display the correct bootloader type (GRUB or Syslinux) instead of always showing Syslinux.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026 •
edited
Loading

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.05.12.0850
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2635/webgui-pr-2635.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list 
emhttp/plugins/dynamix/BootParameters.page

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2635, or run:

plugin remove webgui-pr-2635

🤖 This comment is automatically generated and will be updated with each new push to this PR.

coderabbitai[bot]
coderabbitai Bot reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@emhttp/plugins/dynamix/BootParameters.page`:
- Line 340: The hardcoded English header "(Current Bootloader Configuration)"
must be localized; update any code that assigns or overwrites the element with
id "current-config-label" so it uses the project's translation function (e.g.,
_("Current Bootloader Configuration") or gettext("Current Bootloader
Configuration")) instead of a plain string, and ensure the dynamic assignment
preserves the translatable label rather than replacing it; apply the same fix
for the other occurrences mentioned around the 1999-2005 range.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 68bd1e47-2cb3-482c-a228-01d090be227d

📥 Commits

Reviewing files that changed from the base of the PR and between aba2552 and 8b002bb.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix/BootParameters.page

Comment thread emhttp/plugins/dynamix/BootParameters.page
@limetech limetech merged commit 373651a into unraid:master May 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

7.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonFair @limetech